timjacksonm / Toss-Up

A would you rather question app. Questions generated using AI technology
https://toss-up.vercel.app
2 stars 1 forks source link

Avatar Fallback should be N/A #29

Closed timjacksonm closed 1 year ago

timjacksonm commented 1 year ago

Currently the Avatar uses the profiles image. If profile image is undefined it uses the profiles first & last name initials. If profile for some reason doesn't have initials we should setup "N/A" as the ultimate fallback.

<Avatar.Fallback>
        {initials ?? "N/A"}
 </Avatar.Fallback>

Before image

After change image

alindsharmasimply commented 1 year ago

Hey @timjacksonm , I want to work on this. Can you please tell me how to get the ENV file?

alindsharmasimply commented 1 year ago

Hey @timjacksonm , any pointers on how to get can I get the .env file?

timjacksonm commented 1 year ago

@alindsharmasimply Hi, thanks for your interest. I haven't quite setup this project so its easy to make contributions yet. If you would like to take this ticket. I can assign it to you. I will get back to you as soon as I have the project setup ready for contributions.

alindsharmasimply commented 1 year ago

Sure @timjacksonm, please assign this one to me. Also, please keep me in loop. Thanks!

timjacksonm commented 1 year ago

@alindsharmasimply Hey! I just sent you an email @ alindsharmasimply@gmail.com with the information you need to get started on this contribution. Please message me here if you have any further questions.

alindsharmasimply commented 1 year ago

Thanks @timjacksonm 👍. Have raised a PR for this issue. Kindly check it out.

timjacksonm commented 1 year ago

Thanks @timjacksonm +1. Have raised a PR for this issue. Kindly check it out.

Your branch that you submitted a PR under was out of sync with Main. If you are still wanting to complete this, I left a comment on your PR on what you will need to do.