timjansen / PinkySwear.js

Promises/A+ compliant in less than 500 bytes
89 stars 12 forks source link

Extending the promise signature works only for the first promise in a chain #8

Closed naugtur closed 10 years ago

naugtur commented 10 years ago

I didn't pass extend down to the recursively called constructor. Didn't spot it.

timjansen commented 10 years ago

No problem, will make another release.

Tim

On Mon, Jul 21, 2014 at 11:29 AM, Zbyszek Tenerowicz < notifications@github.com> wrote:

I didn't pass extend down to the recursively called constructor. Didn't spot it.

— Reply to this email directly or view it on GitHub https://github.com/timjansen/PinkySwear.js/issues/8.

naugtur commented 10 years ago

Could you please make the 2.2.2 release or let me do it? I need this feature and it's still not there.

timjansen commented 10 years ago

It's tagged and on npm.

Tim

On Wed, Jul 30, 2014 at 11:54 AM, Zbyszek Tenerowicz < notifications@github.com> wrote:

Could you please make the 2.2.2 release or let me do it? I need this feature and it's still not there.

— Reply to this email directly or view it on GitHub https://github.com/timjansen/PinkySwear.js/issues/8#issuecomment-50595313 .

naugtur commented 10 years ago

Great, thanks!