timjmiller
commented
2 years ago Thanks Cole for trying this option and finding the bug. I will get this fixed on devel branch. No need for you to change your settings.
On Feb 26, 2022, at 12:24 AM, Cole Monnahan @.***> wrote:
There's a small typo that causes an error in the prepare_wham_input function. You can see it here:
https://github.com/timjmiller/wham/blob/master/R/set_NAA.R#L14
where the == turns it into a boolean (or maybe NULL?) which causes a downstream error. Needs to just be =. I was going to do a PR but apparently we have line returns configured differently. I'll need to configure locally to match your EOL settings on git before doing PRs like in your preferred workflow.
— Reply to this email directly, view it on GitHub https://github.com/timjmiller/wham/issues/55, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIGN7G4TSOOH3RSALHGWD3U5BPXJANCNFSM5PMBWTRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
jimianelli
There's a small typo that causes an error in the
prepare_wham_inputfunction. You can see it here:https://github.com/timjmiller/wham/blob/master/R/set_NAA.R#L14
where the
==turns it into a boolean (or maybe NULL?) which causes a downstream error. Needs to just be=. I was going to do a PR but apparently we have line returns configured differently. I'll need to configure locally to match your EOL settings on git before doing PRs like in your preferred workflow.