search

timjmiller / wham

State-space, age-structured fish stock assessment model
https://timjmiller.github.io/wham
Other
32 stars 16 forks source link

paa and do_osa #67

Closed GiancarloMCorrea closed 2 years ago

GiancarloMCorrea commented 2 years ago

A small constant needs to be added to paa_pred here, if not the dmultinom returns NaN when zeros are present.

do_osa is not passed to other functions from get_acomp_ll when age_comp_model == 1, 2, 3, 4 (see here)

timjmiller commented 2 years ago

Thanks! I added this back in for multinomial here

The OSA code has changed substantially and all models fitting should perform equivalently without having to specify any OSA flags. If you find this is not so, please open a separate issue.