search

timjmiller / wham

State-space, age-structured fish stock assessment model
https://timjmiller.github.io/wham
Other
32 stars 16 forks source link

Incorrect indexing for CAA simulation? #73

Closed ahart1 closed 1 year ago

ahart1 commented 1 year ago

simulate_data types are catch, indices, Ecov which can be referenced in the .cpp file as simulate_data(0), simulate_data(1), and simulate_data(2) respectively. However, the simulation code for CAA appears to be dependent on simulate_data(1) (index type) rather than simulate_data(0) (catch type).

https://github.com/timjmiller/wham/blob/6c30301d5b68c2bb0c0330cc4f112432c7950dfd/src/wham_v0.cpp#L1039

timjmiller commented 1 year ago

Thanks @ahart1. Now fixed on devel branch.