search

timjroberts / cucumber-js-tsflow

Provides 'specflow' like bindings for Cucumber.js in TypeScript 1.7+.
MIT License
133 stars 34 forks source link

Adds before and after step hooks #145

Closed cjmarkham closed 6 months ago

cjmarkham commented 6 months ago

Adds support for Cucumber beforeStep and afterStep hooks.

Fryuni commented 6 months ago

Thanks for the PR!

The code looks great. I left two small change requests to the tests to avoid future regressions.

cjmarkham commented 6 months ago

Thanks for the PR!

The code looks great. I left two small change requests to the tests to avoid future regressions.

I'll address when I can. Thanks for the review.

cjmarkham commented 6 months ago

@Fryuni I've addressed your comments.

Fryuni commented 6 months ago

Thank you for tackling this, I'll double-check it tomorrow (because I'm not sober right now) and if everything is ok, I'll merge and cut a release.