Closed bmac closed 1 month ago
Can we have tests for ESM support?
I'd love to see this feature as well. Is there an update?
I'm not personally using cucumber-tsflow on any ESM project, so I'm not pushing for this myself.
I don't have any other points besides the comments above, if anyone wants to add tests for it I'll be glad to review 😁
I'll try to find some time later this week to add tests and clean this up.
This PR is stale because it has been 60 days with no activity. Remove stale lable or comment or this will be closed in 7 days.
There hasn't been any activity on this PR for 67 days. Closing it as Spoiled.
I have a remix project where I'm using
cucumber-tsflow
and the root of my project has"type": "module"
in it's package.json. Unfortunately this changes how node resolves modules in a way that makes it which makes it somewhat cumbersome to work withcucumber-tsflow
's exports. As a result I end up doing this:Annoyingly, the usually fix for this issue is for the library to accept some additional complexity and ship multiple implementations one in the commonjs format and one in the esm format. So that is what the PR attempts to do.
The current implementation of this pr would require a major version bump because
"type": "module"
users such as myself would no longer see a default export and would need to change their code to use named exports.I don't believe there is any impact for user without
"type": "module"
. Additionally if you would prefer to avoid a major version bump we can create a default export for the"type": "module"
users that matches the current behavior.