search

timjroberts / cucumber-js-tsflow

Provides 'specflow' like bindings for Cucumber.js in TypeScript 1.7+.
MIT License
133 stars 34 forks source link

Accept step patterns that are strings #30

Closed edenworky closed 6 years ago

edenworky commented 6 years ago

Cucumber.js step definitions can accept strings instead of Regex, and parameter types depend on that.

mikehaas763 commented 6 years ago

@timjroberts maybe we could get more maintainers added to this repo? So that the community can keep it alive?

timjroberts commented 6 years ago

Absolutely. @mikehaas763 would you be interested?

mikehaas763 commented 6 years ago

@timjroberts definitely! We're already using it, and plan on using it much more extensively in the near future.

timjroberts commented 6 years ago

@mikehaas763 - I've sent you an invite to become a collaborator on this repo. Do you have an npmjs.com account so that I can also add you as a package owner. You'll then be able to make releases.

Thanks for volunteering by the way!

mikehaas763 commented 6 years ago

@timjroberts yeah it's the same as my github username. Glad I can help!

timjroberts commented 6 years ago

@mikehaas763 - You're now also an owner of the NPM package. Let me know if you have trouble publishing.

rliebz commented 6 years ago

Anything still holding up this change? I'd love to see this merged.

mikehaas763 commented 6 years ago

@rliebz nope I’m actually actively working on it, should be coming soon!

mikehaas763 commented 6 years ago

Actually, I was going to upgrade a couple of things, but I’ll just merge the existing PR first, then do a bit of modernization.

mikehaas763 commented 6 years ago

I've merged this, but am unable to publish because I haven't been able to figure out the exact recipe required yet to get it building with the old typings mechanism (https://github.com/typings/typings). Converting it to use @types requires a minimum of TypeScript 2.x.x. When I upgrade to that, I then get code compilation errors.

So, if someone wants to take a stab at it to see if they can figure out the exact steps and environment conditions needed to properly build master, please feel free to 🙂 . Otherwise, I'm just going to continue down my path of "typescript modernization" for this repo which should inadvertently fix this problem.