search

timjroberts / cucumber-js-tsflow

Provides 'specflow' like bindings for Cucumber.js in TypeScript 1.7+.
MIT License
133 stars 34 forks source link

[WIP] beforeAll/afterAll hooks #48

Closed kferrone closed 1 year ago

kferrone commented 4 years ago

I made an attempt to add the BeforeAll and AfterAll. I came across some issues, unfortunately the hooks do not work yet. Mainly, I am having a hard time understanding how the step-binding-flags actually work. I simply followed the pattern and added two more flags and then added the decorators in hook-decorators

Lastly, I simplified the tag filter on the hooks so you now must have an @ on your tag which enables more in depth tag expressions like not @Foo.

Anyone see what's missing to get this to work? Help would be appreciated.

Related Issues

Fixes #47 Fixes #41

Testing

Since the before all and after all are supposed to run after all scenarios, I added a second scenario to the test gherkin. Then I added the before/after all hooks with some simple consol.log for now.

kferrone commented 4 years ago

I see . . . Something must be done in this file: binding-decorators

OhadR commented 2 years ago

@timjroberts , is this going to be merged to master?

78

41