search

timjroberts / cucumber-js-tsflow

Provides 'specflow' like bindings for Cucumber.js in TypeScript 1.7+.
MIT License
133 stars 34 forks source link

Upgrade the library to use Cucumber's latest package #70

Closed sroze closed 4 years ago

sroze commented 4 years ago

As discussed in https://github.com/cucumber/cucumber-js/issues/1369, a pre-release for cucumber-js (package renamed @cucumber/cucumber) has been released.

This pull-request proposes to release a new major version of this one, using this new package.

sroze commented 4 years ago

👋 @timjroberts would you have some time to look at this PR?

sroze commented 4 years ago

Or maybe @wudong as you have been pushing most of the updates recently?

wudong commented 4 years ago

yeah, will do this weekend.

On Tue, Sep 29, 2020 at 6:26 PM Samuel ROZE notifications@github.com wrote:

Or maybe @wudong https://github.com/wudong as you have been pushing most of the updates recently?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timjroberts/cucumber-js-tsflow/pull/70#issuecomment-700863446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJFJJRWUF4EJ6VXPSKRATSIIKENANCNFSM4RQ6G52A .

sroze commented 4 years ago

Thank you 🙌

On Tue, Sep 29, 2020 at 7:22 PM Wudong Liu notifications@github.com wrote:

yeah, will do this weekend.

On Tue, Sep 29, 2020 at 6:26 PM Samuel ROZE notifications@github.com wrote:

Or maybe @wudong https://github.com/wudong as you have been pushing most of the updates recently?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/timjroberts/cucumber-js-tsflow/pull/70#issuecomment-700863446 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AACJFJJRWUF4EJ6VXPSKRATSIIKENANCNFSM4RQ6G52A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timjroberts/cucumber-js-tsflow/pull/70#issuecomment-700895575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGEOEKRJ7GR6QLRPJYBTWLSIIQVFANCNFSM4RQ6G52A .

wudong commented 4 years ago

Hi Sroze, thanks for the PR, I have merge it now but will wait for cucumber 7.0.0 to become official to do a full release of tsflow.

sroze commented 4 years ago

That’s great, thank you @wudong. Do you mind making a release candidate like they did for cucumber so I can try on a few projects to validate it works well? 👌