Closed wudong closed 1 year ago
Is there anything outstanding for this one?
would it be possible to merge this one? timeout on @before/@after would be great
I would also like this one to merge. I want timeout on before/after
Hey @bryant-svedin-gehc, thanks for bringing this up.
Some of the changes on this PR have already landed separately, so you might want to check the latest rc. I'll have a look into adding a step-specific timeout accounting for the new changes.
I am using "cucumber-tsflow": "^4.0.0-rc.7" It does not appear to be able to set the timeout in before/after I can set timeout in given, when, then steps I would like to have timeout on before/after
Also, are there plans for a beforeFeature/afterFeature or could be called beforeAll/afterAll? The current before/after run with each scenario It would be nice to be able to have some configuration/cleanup run only once with the entire feature
@wudong I just merged this with some changes:
undefined, undefined, {...}
For compatibility, the existing signatures also works@bryant-svedin-gehc The new signature is on the README
I'll check #51 for the beforeAll
/afterAll
support. I'll cut a new RC later today, if I can fix on that PR and get it merged before that you'll be able to test both, otherwise I'll cut another RC monday (maybe).
With these changes in place I'll add some more tests for them and if everything is stable I'll cut a proper v4 release
I just pulled 4.0.0-rc.9 Thanks for including these changes. I really appreciate it. This package has been great.
Minor note: The method description for beforeAll/AfterAll are identical to before/after