search

timjroberts / cucumber-js-tsflow

Provides 'specflow' like bindings for Cucumber.js in TypeScript 1.7+.
MIT License
133 stars 34 forks source link

@before with tag is not working properly with cucumberjs > 0.9.5 #9

Closed alexwizp closed 8 years ago

alexwizp commented 8 years ago

For more details see https://github.com/cucumber/cucumber-js/blob/master/CHANGELOG.md

Section: updated tagged hook interface (Charlie Rudolph)

how to update:

this.Before('@tagA', function() { ... }) // becomes this.Before({tags: ['@tagA']}, function() { ... })

this.Before('@tagA', '@tagB,@tagC', function() { ... }) // becomes this.Before({tags: ['@tagA', '@tagB,@tagC']}, function() { ... })

alexwizp commented 8 years ago

Also it will be great if you add ability to set timeout for Hooks(@before and @after)

TAGC commented 8 years ago

WHO DISTURBS MY SLUMBER

alexwizp commented 8 years ago

@timjroberts Do you have any updates?

timjroberts commented 8 years ago

Will try and take a look as soon as I can. Family commitments are occupying my evenings at the moment.

AlexandrosD commented 8 years ago

For now a downgrade to cucumber v0.9.5 does the trick, but we miss the other goodies..

timjroberts commented 8 years ago

Hopefully this will now be fixed in v1.2.0. Let me know how it goes!

AlexandrosD commented 8 years ago

I can confirm that it works as expected, at least with one tag passed to the @before() or @after()