search

timkay / aws

Easy command line access to Amazon EC2, S3, SQS, ELB, and SDB
http://timkay.com/aws/
427 stars 126 forks source link

add RDS log file commands #92

Closed ryanbarry closed 9 years ago

ryanbarry commented 9 years ago

had the need to programmatically access log files today, didn't see the endpoints in the script so i did my best to follow conventions i saw and add them.

i'm unsure about the short names i chose for the commands and parameters, so i'm definitely open to feedback there

timkay commented 9 years ago

Ryan, sounds good. Please see if you can make the commands match http://docs.aws.amazon.com/AmazonRDS/latest/CommandLineReference/command-reference.html

ryanbarry commented 9 years ago

i thought they matched pretty well, only differences i note in looking back over the docs is that i've added the extra params available via the API to download-db-log-file-portion vs the CLI, but i assume that's OK, right? is there anything else i'm missing?

ryanbarry commented 9 years ago

though, the CLI command doesn't exactly correspond to the API, so should i make a command that mirrors the CLI in addition to the one that exposes the API more directly?

timkay commented 9 years ago

I misunderstood from your original post when you said you didn't know if you named them right. However, you now indicate that you did a pretty good job. I'll go ahead and merge. Thanks!