timkay / aws

Easy command line access to Amazon EC2, S3, SQS, ELB, and SDB
http://timkay.com/aws/
426 stars 126 forks source link

Needs MIME::Base64 to support userdata #94

Closed asergeyev closed 9 years ago

asergeyev commented 9 years ago

It looks like function from that module was used for UserData encoding but was use statement is missing. Adding it fixes the problem.

timkay commented 9 years ago

Thanks for catching it. Looking back at the code, we see

Jim Dannemiller says MIME::Base64 was missing from the Perl installation

on a small Linux handheld, so I added this code here instead of including

MIME::Base64.

Since then, to support V4 authentication, I started using core MD5, etc. functions and removed the ones that were coded in. I accidentally deleted a section of code with the Base64 functionality and also something that was needed for R53.

I'll guess that the small Linux handheld is also missing the core MD5, etc., so we will move forward with a modern core as a requirement. If you need to run on smallish hardware, an older version should work for you. Otherwise, let me know, and we will start adding back some of this code.

asergeyev commented 9 years ago

Maybe for those could be possible to make util to do App::FatPacker to build all code at once in one executable. But for general audience it would be overkill. Thanks! Great tool!

asergeyev commented 9 years ago

Also you could always replace it to eval 'use MIME::Base64 qw(...)'; and it'll help those setups but IMO it makes everything not as pretty :)