search

timkeane / nyc-lib

Apache License 2.0
12 stars 8 forks source link

Dialog options #40

Closed cmenedes closed 3 years ago

cmenedes commented 3 years ago

Current Behavior

Splash window contains no text if dialog options message is passed as a string. image

Expected Behavior

Dialog options message should be able to be passed as a string. User should see message text in splash window.

Failure Information (for bugs)

Steps to Reproduce

  1. Open finderapp.html located in the examples/ol folder
  2. Provide splashOptions to the FinderApp constructor (the message should be a string): splashOptions: {message: 'splash page message'}`
  3. Build nyc-lib as described in readme, navigate to dist/examples/ol/finderapp.html
  4. Observe if the message text appears in the splash window
cmenedes commented 3 years ago

Addressed in b2d0b28