search

timkendrick / recursive-copy

Simple, flexible file copy utility
96 stars 18 forks source link

Upgrade `rimraf` dependency to satisfy npm install warnings #44

Closed zachleat closed 1 month ago

zachleat commented 2 months ago

Looks like folks are getting npm install warnings from this package, is it possible to upgrade the rimraf package version? Or would you accept a PR of an upgrade? Looks like it might be a major version bump (the latest rimraf is v5).

Changelog here: https://github.com/isaacs/rimraf?tab=readme-ov-file#major-changes

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

Related: https://github.com/11ty/eleventy/issues/3299

zachleat commented 1 month ago

We resolved this in Eleventy by forking: https://github.com/11ty/recursive-copy/

If you’d like these dependency updates merged back upstream, I’m happy to PR this but I think long term we’re trying to move towards Node-native fs.cp so I don’t blame y’all if this package is retired (https://github.com/11ty/eleventy/issues/3360)

Thanks!