timkpaine / jupyterlab_autoversion

Automatically version jupyter notebooks in JupyterLab
https://jupyterlab-autoversion.readthedocs.io
Apache License 2.0
75 stars 10 forks source link

No previous version showed #91

Closed Betristor closed 2 years ago

Betristor commented 2 years ago

Describe the bug No previous version showed.

To Reproduce Steps to reproduce the behavior:

  1. Create a new notebook
  2. Run some code
  3. Click the auto version button
  4. See error

Expected behavior Previous versions are shown.

Screenshots

image

Desktop (please complete the following information):

Additional context

Traceback (most recent call last):
       File "/opt/tljh/user/lib/python3.9/site-packages/tornado/web.py", line 1702, i>
         result = method(*self.path_args, **self.path_kwargs)
       File "/opt/tljh/user/lib/python3.9/site-packages/tornado/web.py", line 3173, i>
         return method(self, *args, **kwargs)
       File "/home/jupyter-zyh/.local/lib/python3.9/site-packages/jupyterlab_autovers>
         version = int(self.get_argument("version", 0))
     ValueError: invalid literal for int() with base 10: 'undefined'
timkpaine commented 2 years ago

@Betristor did you save the notebook before you clicked the button to restore an old version? Working fine for me on a fresh jupyterlab 3.4.0 / autoversion 0.3.6 install.

Betristor commented 2 years ago

Yep, after I saved the file, a version showed in the panel.