timkurvers / redota

Revisit past Dota 2 matches in the browser
https://timkurvers.github.io/redota
MIT License
51 stars 7 forks source link

feat: support The Dragon's Gift protobufs #102

Closed Tsury closed 6 months ago

Tsury commented 6 months ago

The latest protobufs introduced with The Dragon's Gift update changed is_delta to legacy_is_delta and introduced a bunch of other fields.

timkurvers commented 6 months ago

Oh, one more thing, we should probably also include the actual changes in the dota/*.proto files.

Tsury commented 6 months ago

Fanastic, thanks for looking into this 🥳

Could you have a look at yarn lint to see if there are any linting things that need cleaning up?

Just did, no issues in Parser.js. There are some pre-existing issues btw:

4:8   error  Expected a line break after this opening brace   object-curly-newline
4:55  error  Expected a line break before this closing brace  object-curly-newline

src\ui\hooks\useReplayController.jsx
21:23  warning  Unexpected console statement  no-console

src\ui\pages\main\Matches.jsx
7:8  error  'Icon' is defined but never used  no-unused-vars
Tsury commented 6 months ago

Updated the protos, used emitter warn event and ensured no new linting issues ✌️

timkurvers commented 6 months ago

Awesome thanks! 🥳 Oh yeah, I will have a look at those, thanks 🙏