timkurvers / valheim-macos

Build-your-own Valheim build for macOS
MIT License
270 stars 14 forks source link

Public test build, please? #29

Closed hvab closed 1 year ago

hvab commented 1 year ago

Any chance to get public test build by this script? For example latest Hildir's patch.

timkurvers commented 1 year ago

Hi there! That should be technically possible. I may have a look at it this weekend if time permits.

hvab commented 1 year ago

It would be great! Thank you! I tried to transfer new data from the Steam depot to the script myself, but I got stuck with the fact that the test branch has a password (yesimadebackups) and did not find the manifest for the test build.

osirion commented 1 year ago

Tried doing this myself by modifying the version and buildid. It downloaded the files, but then failed at the step after with a "cp" failure. No such file or directory since it appears to have downloaded the files into the 11422039 (normal) directory instead of the 11535571 (public-test) directory.

osirion commented 1 year ago

This is how I resolved it: edit build.sh:

buildid=11535571
manifestid=9217850553460069452
version="0.217.6"
beta="public-test"
betapassword="yesimadebackups"

Then edit the line that looks like so: dotnet depotdownloader-2.4.7/DepotDownloader.dll -app $appid -depot $depotid -manifest $manifestid -os linux -username "$username" To be like so: dotnet depotdownloader-2.4.7/DepotDownloader.dll -app $appid -depot $depotid -manifest $manifestid -os linux -username "$username" -beta "$beta" -betapassword "$betapassword"

osirion commented 1 year ago

Ok, correction, the above would of worked - I'm sure, if one had the correct manifestid - which I cannot seem to find for the life of me...

timkurvers commented 1 year ago

Thanks for looking into this @osirion!

If I remember correctly the only reason we specified the manifest ID was due to a Steam platform bug. This has been worked around in DepotDownloader 2.5.0. So in theory using that particular version (or newer) and dropping -manifest altogether should work. I managed to get a hold of the beta files that way.

Have the following idea in my head: putting this beta-variant of the script in a beta-branch here on GitHub, which would allow us to keep the main script clean. Just haven't had the time to test it out yet. 😊

osirion commented 1 year ago

Ahh! Great, can confirm that updating the build script to use Depot Downloader 2.5 did the trick. Was able to run the public-test version with no issues then :) Thanks @timkurvers !

hvab commented 1 year ago

Ahh! Great, can confirm that updating the build script to use Depot Downloader 2.5 did the trick. Was able to run the public-test version with no issues then :) Thanks @timkurvers !

Hello @osirion! Can you please share the build.sh code? The above example doesn't work for me even if I set Depot Downloader 2.5.

osirion commented 1 year ago

@hvab - something like this...

# Valheim configuration
appid=892970
depotid=892971
#buildid=11422039
#manifestid=9217850553460069452
#version="0.216.9"
buildid=11535571
version="0.217.6"
beta="public-test"
betapassword="yesimadebackups"

Then further down by the depotdownloader check (note, I commented out the verify command because I dont know the hash for 2.5.0):

    if [ ! -d "depotdownloader-2.5.0" ]; then
      if confirm "Download (~2MB) and unzip DepotDownloader to download Valheim from Steam?"; then
        curl -L https://github.com/SteamRE/DepotDownloader/releases/download/DepotDownloader_2.5.0/depotdownloader-2.5.0.zip -o depotdownloader-2.5.0.zip
        #verify depotdownloader-2.5.0.zip acee4d813db4e6908b75d348767cf01e
        unzip depotdownloader-2.5.0.zip -d depotdownloader-2.5.0
      fi

      if [ ! -d "depotdownloader-2.5.0" ]; then
        echo "DepotDownloader not found, exiting.."
        exit 1
      fi
    fi

@timkurvers - If it was me, I dont know if I would have a separate build for beta. Maybe just have one script which accepts a /beta flag and used the vars in the script, or accepts -beta [depotname] and -betapassword [pw] flags??

hvab commented 1 year ago

@osirion Thank you! I don't know why, but with these parameters it still creates the app version 0.216.9...

UPDATE. My bad - need to delete old depot first. Confirm - it's work!

timkurvers commented 1 year ago

Glad you two have working versions! 🥳

Have opened up #31 which has support for the --beta flag. I won't be able to get around to merging it today, but later this week hopefully.

timkurvers commented 1 year ago

Closing as this is now available on the main branch. Thanks for the detective work! 🙌