timlau / yumex-dnf-old

Next Generation of Yum Extender using DNF as backend
GNU General Public License v2.0
61 stars 17 forks source link

[RFE] add dark theme support #102

Closed genodeftest closed 3 years ago

genodeftest commented 8 years ago

There are some minor issues with dark themes, e.g.:

There are some common issues that don't fit there, so I'm opening a new bug report to lay out an idea how to fix this.

Workaround: disable dark theme altogether. gnome-calendar does this. This could be shipped pretty fast.

How to actually fix colors:

Alternative approach as suggested by Gtk+ developer Matthias Clasen:

This seems to be "the modern Gtk+ 3.x way". This is nice and clean, but doesn't fix the problem for unknown dark themes without gtk-application-prefer-dark-theme set. Gtk+ people don't seem to care about that though.

If nobody objects, I'll be working on this.

timlau commented 8 years ago

Agree there is some issues with "Dark" themes, It would be great if you would look into it.

genodeftest commented 8 years ago

Theme detection is working: https://gist.github.com/genodeftest/94e623123f20566d158569a2ef3b25a2

timlau commented 3 years ago

Dark themes is working fine in current release and support for custom yumex themeing is added