timlau / yumex-dnf-old

Next Generation of Yum Extender using DNF as backend
GNU General Public License v2.0
61 stars 17 forks source link

yumex should restart statusicon, when upgrading itself #44

Closed timlau closed 9 years ago

timlau commented 9 years ago

when statusicon is set to autostart and yumex-dnf update itself and the user closes the gui then the old version statusicon is still running and if there is some api changes, then yumex-dnf might fail if the statusicon applet is not quited.

rapgro commented 9 years ago

This could happen when dnfdaemon-system is still running as root, I logged off and login again but the daemon seems to survive and I killed it manually. Yumex-dnf restarted a new root process and works.

genodeftest commented 9 years ago

Wouldn't it be easier to use GtkApplication to make sure that only one instance of yumex-dnf is running? In this case the dbus part could be moved into yumex-dnf, so only one application running as user is being left. GApplication doesn't need to have a window running, see e.g. nautilus on Gnome 3.16/3.18. In this case you wouldn't need to check the statusicon version in yumex-dnf. It looks like GtkStatusIcon is going away on Gnome anyway. And having just one application with less version checks might ease testing & debugging.

timlau commented 9 years ago

The idea with the separate StatusIcon app was to have a small memory footprint app there can check for updates and launch the gui on user request. It is also uses to checked if another version is already running, this part can properly be implemented in GtkApplication, but the docs for using GtkApplication in python is not the best, when I tarting to use it, but it can have been improved since.

timlau commented 9 years ago

Fixed in the current 4.3.x development versions

Se #79 for details