search

timlau / yumex-dnf-old

Next Generation of Yum Extender using DNF as backend
GNU General Public License v2.0
61 stars 17 forks source link

Change font colors if using dark theme #49

Closed tamimym closed 9 years ago

tamimym commented 9 years ago

I created a function that checks if gtk is using a dark theme. In which case, I adjust the colors so that they become readable. Here's a screenshot of the finished work.

screenshot from 2015-07-28 23-21-56

rapgro commented 9 years ago

Cool feature, thanks. :+1: Although, yumex-dnf should prefer font settings from the currently applied theme, so your gtk theme propably have to use readable fonts.

timlau commented 9 years ago

Merged, Thanks

genodeftest commented 9 years ago

These changes break font color on light themes. All black fonts (available packages) are now white which is unusable on a light Gtk3 theme. The check you added (check_dark_theme) is correctly detecting a light theme. Everything else (background color, green fonts for installed packages, fonts for package description, package update info, package file list, package requires list, …) is working fine though.

And I second @rapgro, using fonts from the theme should be preferred.

timlau commented 9 years ago

There was a bug, I have fixed it

https://github.com/timlau/yumex-dnf/commit/0313edf9a7b3d3c7bac23e0d9ef03ffd824de630

timlau commented 9 years ago

Agree, this is a work around and a better way is to get colors from the theme.

yumex-dnf has a feature so a theme author can supply a speciel .css file to configue the look and feel of yumex-dnf

(See #26 for details)