search

timlrx / tailwind-nextjs-starter-blog

This is a Next.js, Tailwind CSS blogging starter template. Comes out of the box configured with the latest technologies to make technical writing a breeze. Easily configurable and customizable. Perfect as a replacement to existing Jekyll and Hugo individual blogs.
https://tailwind-nextjs-starter-blog.vercel.app/
MIT License
7.36k stars 1.84k forks source link

feat: Add hidden to mobile nav #940

Closed Spiteless closed 2 weeks ago

Spiteless commented 3 weeks ago

Fix

Added hidden class to navShow classes so that the MobileNav elements are removed from tab indexing order.

Expected behavior:

Pressing tab will navigate through visibile links, buttons

Current behavior before PR:

Pressing tab will switch from ThemeSwitch icon to MobileNav links, which are hidden on larger screens

vercel[bot] commented 3 weeks ago

@Spiteless is attempting to deploy a commit to the timlrx's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-nextjs-starter-blog ❌ Failed (Inspect) Jun 17, 2024 9:11am
timlrx commented 3 weeks ago

Thanks, good catch. Run prettier and I will re-deploy the updated version.

Spiteless commented 2 weeks ago

Looks like I just got husky and prettier working but they aren't applying any changes to this PR.

# Terminal output

a9e6592 Trillium Smith  feat: Add hidden class to MobileNav navShow conditional render                    (HEAD -> ts.add_hidden_to_MobileNav, origin/ts.add_hidden_to_MobileNav)
391f4c6 Timothy         Merge pull request #934 from JcobCN/main                                          (upstream/main)
cdb30e7 Timothy         Merge pull request #935 from timlrx/update-kbar-docs                             %                      

# Run yarn lint
yarn lint

✔ No ESLint warnings or errors
Spiteless commented 2 weeks ago

This PR will be redundent if #943 is merged, closing