search

timmbogner / Farm-Data-Relay-System

A system that uses ESP-NOW, LoRa, and other protocols to transport sensor data in remote areas without relying on WiFi.
MIT License
485 stars 108 forks source link

Updating LoRa functions to fix ACK and CRC issues. #119

Closed aviateur17 closed 1 year ago

aviateur17 commented 1 year ago

Correcting issue with node ACK/CRC replies per discussion #110 https://github.com/timmbogner/Farm-Data-Relay-System/discussions/110#discussioncomment-4118280

timmbogner commented 1 year ago

Thanks Jeff, I really appreciate it. I started looking at it the other day and realized I'd need to devote more time than I had at the moment.

Unfortunately I may have thrown another wrench in the gears... Unlike this summer, I've been updating the 'main' branch regularly and haven't touched the 'dev' branch, except last month when I used it for an experiment where I disabled the uniqueID functionality and left it that way. I am assuming you started this branch with timmbogner/dev, and as such it is missing a few important commits from the last few weeks. I'm hoping there's an easy way to deal with this. If I pull 'main' into 'dev', before I pull this one, I think that will help? I'm so sorry for complicating things further.

aviateur17 commented 1 year ago

I am assuming you started this branch with timmbogner/dev, and as such it is missing a few important commits from the last few weeks. I'm hoping there's an easy way to deal with this. If I pull 'main' into 'dev', before I pull this one, I think that will help? I'm so sorry for complicating things further.

Yeah I changed the dev branch. Now that I know what to change it wouldn't be hard to do the same on the main branch. I can do that if it would be better. Wouldn't take much work.

timmbogner commented 1 year ago

I can do that if it would be better.

That would probably be best, less chance of me screwing something else up. Thanks again, you're awesome!

aviateur17 commented 1 year ago

Closing this PR as I will implement the changes on the main branch.