search

timmbogner / Farm-Data-Relay-System

A system that uses ESP-NOW, LoRa, and other protocols to transport sensor data in remote areas without relying on WiFi.
MIT License
485 stars 108 forks source link

Fix LoRa ACK/CRC issues in main branch #121

Closed aviateur17 closed 1 year ago

aviateur17 commented 1 year ago

Correcting issue with node ACK/CRC replies per discussion https://github.com/timmbogner/Farm-Data-Relay-System/discussions/110

https://github.com/timmbogner/Farm-Data-Relay-System/discussions/110#discussioncomment-4118280

aviateur17 commented 1 year ago

I see why the #import statements are in the middle of the fdrs_functions file now. I'm going to try to revert that change as the effort to move the related LoRa variables to the LoRa functions would require a lot of work.

timmbogner commented 1 year ago

Awesome! I had to move the functions around again and declare getLoRa(). Sorry for the confusion with the imports. I'm going to read up on how to organize the code better, and possibly re-factor it into a more proper library (using @Devilbinder's work as a guide.)

I tested a LoRa sensor to a gateway, as well as an ESP-NOW sensor to a LoRa repeater to a gateway. Both were successful! Let me know if I messed anything up, otherwise I'll pull this later tonight.