search

timmbogner / Farm-Data-Relay-System

A system that uses ESP-NOW, LoRa, and other protocols to transport sensor data in remote areas without relying on WiFi.
MIT License
485 stars 108 forks source link

Fix Arduino compile issue as mentioned in issue #86 #88

Closed aviateur17 closed 1 year ago

aviateur17 commented 1 year ago

Synchronization between two fdrs_sensor.h files which caused issues in Arduino compilation. Also not sure why crc16_update prototype on line 105 is required by Arduino. I just added it instead of figuring out why Arduino needs it. PlatformIO does require function prototypes if the functions are used before they are defined but my understanding was that Arduino handled that situation without requiring the prototypes.

aviateur17 commented 1 year ago

@Gulpman, I tried one or two of the gateway sketches and thought they did compile. I will go and check them all right now. Sorry for missing this.

timmbogner commented 1 year ago

Just let me know when things are ready to merge.

Many thanks!

aviateur17 commented 1 year ago

@Gulpman, I tested examples 1 through 5 and the first example under Sensor_Examples and they compile correctly with the function prototypes added in. It seems that the Universal Gateway stuff is being maintained by someone else so I didn't try to compile those. I made a note of why the Stress test would not compile in #86. The sketches in the Controllers folder do not seem like they are being maintained so I'm not sure if those are to be tested or not. This is one of the reasons why the project structure is a bit confusing.