timmcmic / DLConversionV2

MIT License
44 stars 9 forks source link

Update Get-MigrationSummary.ps1 #47

Closed mprentice22153 closed 2 years ago

mprentice22153 commented 2 years ago

Updated the code for determining the group name and status for successJobs and failedJobs. Issues occur when the distribution group included hyphens in the name, such as "Sales-ThousandOaks" and "L-HR". Also replaced all double quotes with single quotes when there is no variable interpretation needed.

mprentice22153 commented 2 years ago

Disregarding all the quote mark changes, there are only 2 sections of 4 lines each, that were changed.

timmcmic commented 2 years ago

Squashed and merged - thanks for the contribution!

============================== Timothy J. McMichael Senior Support Escalation Engineer @.**@.> (980)-776-7465

Hours: Sunday – Wednesday 08:00 – 16:00 eastern time zone.

Manager: Tom Roughley @.**@.>)

Premier Support - (800)-936-3100 Broad Commercial Support - (800)-936-4900

==============================


From: MPrentice @.> Sent: Friday, April 15, 2022 12:55 AM To: timmcmic/DLConversionV2 @.> Cc: Subscribed @.***> Subject: [timmcmic/DLConversionV2] Update Get-MigrationSummary.ps1 (PR #47)

Updated the code for determining the group name and status for successJobs and failedJobs. Issues occur when the distribution group included hyphens in the name, such as "Sales-ThousandOaks" and "L-HR". Also replaced all double quotes with single quotes when there is no variable interpretation needed.


You can view, comment on, or merge this pull request online at:

https://github.com/timmcmic/DLConversionV2/pull/47https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftimmcmic%2FDLConversionV2%2Fpull%2F47&data=05%7C01%7Ctimmcmic%40microsoft.com%7C5bbeb21caae04ab97ac408da1e9c30c3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637855953440645083%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OM%2B%2BTvQvyzfPjt0mWe8sdt24sjnsms%2BHV99Avr7oPyo%3D&reserved=0

Commit Summary

File Changes

(1 filehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftimmcmic%2FDLConversionV2%2Fpull%2F47%2Ffiles&data=05%7C01%7Ctimmcmic%40microsoft.com%7C5bbeb21caae04ab97ac408da1e9c30c3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637855953440695059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WezpuzCpG02VFB6O5ESyCtDEIzqBxe5bH5RKECFxLvs%3D&reserved=0)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftimmcmic%2FDLConversionV2%2Fpull%2F47&data=05%7C01%7Ctimmcmic%40microsoft.com%7C5bbeb21caae04ab97ac408da1e9c30c3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637855953440695059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BMfhZgnDDaIPY5C%2FPURW43lEwThdxYF5zBI7pY9NR6s%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKGTN6KFEMWDBLHKEMUMHBTVFDZEZANCNFSM5TPSIHIQ&data=05%7C01%7Ctimmcmic%40microsoft.com%7C5bbeb21caae04ab97ac408da1e9c30c3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637855953440695059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vEkgMjpNNXOwkDGncNsAmcLApy4nSSOzEdZ8m9fVhik%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>