timmcmic / DLConversionV2

MIT License
44 stars 9 forks source link

Centralized Mail transport is always acknowledged #57

Closed PeterNagl closed 2 years ago

PeterNagl commented 2 years ago

I found that the warning about CMT that should trigger in Test-OutboundConnector.ps1 is always acknowledging the warning (and not halting the migration) even when no override is specified.

In the main function the var is initialized to $false if not set by the parameter:

[boolean]$overrideCentralizedMailTransportEnabled=$FALSE, [Parameter(Mandatory=$false)]

the parameter goes directly to test-outboundConnector try { test-outboundConnector -overrideCentralizedMailTransportEnabled $overrideCentralizedMailTransportEnabled -errorAction STOP }

And in Test-OutboundConnector.ps1 is a typo Parameter is Centralized if is looking for Central

`Param ( [Parameter(Mandatory = $true)] $overrideCentralizedMailTransportEnabled )

    if ($overrideCentralMailTransportEnabled -eq $FALSE)

`

timmcmic commented 2 years ago

Ok I updated this in the refine ad calls branch if you want to test it.

============================== Timothy J. McMichael Senior Support Escalation Engineer @.**@.> (980)-776-7465

Hours: Sunday - Wednesday 08:00 - 16:00 eastern time zone.

Manager: Tom Roughley @.**@.>)

Premier Support - (800)-936-3100 Broad Commercial Support - (800)-936-4900

==============================

From: Peter Nagl @.> Sent: Monday, July 25, 2022 4:52 PM To: timmcmic/DLConversionV2 @.> Cc: Subscribed @.***> Subject: [timmcmic/DLConversionV2] Centralized Mail transport is always acknowledged (Issue #57)

I found that the warning about CMT that should trigger in Test-OutboundConnector.ps1 is always acknowledging the warning (and not halting the migration) even when no override is specified.

In the main function the var is initialized to $false if not set by the parameter:

[boolean]$overrideCentralizedMailTransportEnabled=$FALSE, [Parameter(Mandatory=$false)]

the parameter goes directly to test-outboundConnector try { test-outboundConnector -overrideCentralizedMailTransportEnabled $overrideCentralizedMailTransportEnabled -errorAction STOP }

And in Test-OutboundConnector.ps1 is a typo Parameter is Centralized if is looking for Central

`Param ( [Parameter(Mandatory = $true)] $overrideCentralizedMailTransportEnabled )

if ($overrideCentralMailTransportEnabled -eq $FALSE)

`

- Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftimmcmic%2FDLConversionV2%2Fissues%2F57&data=05%7C01%7Ctimmcmic%40microsoft.com%7Cc29a8234d057468abd2808da6e7f8e2f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943791374495888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PfADcMGiGk2SQ%2FLDBxNkg5YcSHK6yQ0L5b1L%2BrGc%2FMM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKGTN6P5DED2ELMVDNDUFPLVV3475ANCNFSM54TTOSXA&data=05%7C01%7Ctimmcmic%40microsoft.com%7Cc29a8234d057468abd2808da6e7f8e2f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943791374495888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HZIHKE0x6cfJLg5JNIlezGuUC2kJwFk3AwPrizgl1xI%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

PeterNagl commented 2 years ago

Fixed in your last build.