search

timmerk / libfreefare

Automatically exported from code.google.com/p/libfreefare
Other
0 stars 0 forks source link

Wrong types (probably a typo) in two desfire functions #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The function mifare_desfire_get_file_ids() has a parameter uint8_t *files[]. 
The type describes an array of pointers to uint8_t. This is probably not the 
type that was meant to be used, as the argument clearly should be a pointer to 
an array of uint8_t, denoted as uint8_t (*files)[].

I suggest to change the type of files in the signature of 
mifare_desfire_get_file_ids() to uint8_t (*files)[]. As the array decays to a 
pointer in a function declaration, these two types should not make any 
difference in a regard to the calling convention.

A similar issue exists in mifare_desfire_get_iso_file_ids() where the parameter 
uint16_t *files[] should probably be type uint16_t (*files)[].

Original issue reported on code.google.com by fuz...@gmail.com on 5 Apr 2014 at 11:07

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision ffde4d4d92a5.

Original comment by romain.t...@gmail.com on 16 Apr 2014 at 12:39