cutter tests cannot find static functions

GoogleCodeExporter commented 9 years ago

When making checks:

make  check-TESTS
make[2]: Entering directory `.../nfc-tools/git-svn/libfreefare/test'
OOOOOOO/usr/bin/cutter: symbol lookup error: ./.libs/test_mad.so: undefined 
symbol: nxp_crc
FAIL: run-test.sh

This is because nxp_crc() is defined as static in libfreefare/mad.c
Same for sector_0x00_crc8() and sector_0x10_crc8()

Issue is solved by removing the keyword "static" in front of those three 
functions but I'm not sure it's the right thing to expose those internal 
functions.
If they are meant to be internal, why test_mad is calling them?

Original issue reported on code.google.com by yob...@gmail.com on 15 Jan 2013 at 8:12

GoogleCodeExporter commented 9 years ago

Original report: https://code.google.com/p/nfc-tools/issues/detail?id=105

Original comment by yob...@gmail.com on 15 Jan 2013 at 8:13

GoogleCodeExporter commented 9 years ago

Original comment by yob...@gmail.com on 15 Jan 2013 at 8:22

GoogleCodeExporter commented 9 years ago

Fixed in r5fa9f2cbc34d.

Thanks!

Original comment by romu...@libnfc.org on 18 Feb 2013 at 4:09

Changed state: Fixed

timmerk / libfreefare

cutter tests cannot find static functions #6