search

timmerk / nfc-tools

Automatically exported from code.google.com/p/nfc-tools
0 stars 0 forks source link

cutter tests cannot find static functions #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When making checks:

make  check-TESTS
make[2]: Entering directory `.../nfc-tools/git-svn/libfreefare/test'
OOOOOOO/usr/bin/cutter: symbol lookup error: ./.libs/test_mad.so: undefined 
symbol: nxp_crc
FAIL: run-test.sh

This is because nxp_crc() is defined as static in libfreefare/mad.c
Same for sector_0x00_crc8() and sector_0x10_crc8()

Issue is solved by removing the keyword "static" in front of those three 
functions but I'm not sure it's the right thing to expose those internal 
functions.
If they are meant to be internal, why test_mad is calling them?

Original issue reported on code.google.com by yob...@gmail.com on 14 Nov 2012 at 12:04

GoogleCodeExporter commented 9 years ago 
Issue moved to https://code.google.com/p/libfreefare/issues/detail?id=6

Original comment by yob...@gmail.com on 15 Jan 2013 at 8:13