search

timmerk / nfc-tools

Automatically exported from code.google.com/p/nfc-tools
0 stars 0 forks source link

Add regression tests for CRC location in encyphered data files. #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This issue was created by revision r752.

The CRC position location code in mifare_cryto_postprocess_data() shall be
checked.

new issue
Summary: Rework mifare_cryto_postprocess_data() CRC localisations
The function has two different implementation of the same feature: locate a CRC
at the end of a decyphered stream and check it.  The crc32 will fail if the
last CRC byte is 0x80, and the crc16 code looks awful.  A refactoring would
make our life easier.

Original issue reported on code.google.com by rtarti...@il4p.fr on 1 Jan 2011 at 3:27

GoogleCodeExporter commented 9 years ago

Original comment by romain.t...@gmail.com on 1 Jan 2011 at 3:29

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r786.

Both code snippets are now similar and it should be possible to merge them
together.

Original comment by rtarti...@il4p.fr on 23 Apr 2011 at 3:17

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r790.

Original comment by romain.t...@gmail.com on 24 Apr 2011 at 11:45