Improve MFOC stability - Githubissues

timmerk / nfc-tools

Automatically exported from code.google.com/p/nfc-tools

0 stars 0 forks source link

Improve MFOC stability #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

This page describes some improvement. I suggest it should be verified on 
correctness and speed.

http://valentijn.sessink.nl/?p=259

Original issue reported on code.google.com by r...@libnfc.org on 2 Feb 2011 at 12:21

GoogleCodeExporter commented 9 years ago

Will you do this task ?

Original comment by romu...@libnfc.org on 2 Feb 2011 at 1:17

GoogleCodeExporter commented 9 years ago

Original comment by romu...@libnfc.org on 2 Feb 2011 at 1:20

Changed title: Improve MFOC stability
Added labels: Component-mfoc

GoogleCodeExporter commented 9 years ago

Yes I will into it later ;)

Original comment by r...@libnfc.org on 2 Feb 2011 at 1:46

GoogleCodeExporter commented 9 years ago

Original comment by romu...@libnfc.org on 2 Feb 2011 at 2:59

GoogleCodeExporter commented 9 years ago

I merged all mfoc modifications (since article's date till r811) in the revised 
mfoc.c file provided by Valentijn Sessink.
File attached.

Any feedbacks, explanations, tests, etc. are welcome. If reports are good, the 
patch will be applied upstream.

Original comment by romu...@libnfc.org on 18 May 2011 at 3:18

Attachments:

mfoc.c

GoogleCodeExporter commented 9 years ago

Hi, this definitely appears to improve stability.

It was tested with pcsc-lite-1.7.4, ccid-1.4.4 and libnfc-1.5.0 on a 
touchatag/tikitag ACS ACR 38U-CCID 01 00 / ACR122U102.

There is still the occasional problem, but it's far less frequent.  There 
appears to be some kind of timeout that causes everything to pause for many 
seconds every once in a while, but it's not clear if that relates to pcsc-lite, 
libnfc or the hardware.  Either way, this version of mfoc can at least crack 
keys, whereas the other one often threw an error before it could find a single 
key.

Original comment by mike.auty@gmail.com on 9 Aug 2011 at 8:36

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

Here is a walking around modification. I modified mfoc.c

169,174c169
<   while (!nfc_initiator_init (r.pdi)){
<       sleep(1);
<       fprintf(stdout, "e");
<   }
< 
<   /*if (!nfc_initiator_init (r.pdi)) {
---
>   if (!nfc_initiator_init (r.pdi)) {
177c172
<   }*/
---
>   }
558,562c553
<   while (!nfc_initiator_init (pdi)) {
<       sleep(1);
<       fprintf(stdout, "e");
<   }
<   /*if (!nfc_initiator_init (pdi)) {
---
>   if (!nfc_initiator_init (pdi)) {
565c556
<   }*/
---
>   }

Original comment by superli....@gmail.com on 27 Sep 2011 at 1:53

GoogleCodeExporter commented 9 years ago

The partial merge seems to improve user experience and even the while()-patch 
removes failures, its a non-sense patch since it will try until 
nfc_initiator_init() works instead of fixing the problem source.

Feel free to report a new one at https://mfoc.googlecode.com with all 
instructions to be able to reproduce the bug.

Thanks

Original comment by romu...@libnfc.org on 20 Jan 2013 at 4:24

Changed state: Fixed