search

timmhirsens / vscode-elixir

This plugin is no longer maintained!
MIT License
264 stars 50 forks source link

Make language IDs compliant with new identifier guidelines #113

Open timmhirsens opened 6 years ago

timmhirsens commented 6 years ago

Docs: https://code.visualstudio.com/docs/languages/identifiers#_new-identifier-guidelines

This is a breaking change as it may have an influence on other extensions relying on the current ids. The impact will have to be investigated.

Primer: https://github.com/vscode-icons/vscode-icons/issues/1414

JimiC commented 6 years ago

Just a friendly advice. Since this is a breaking change, if you are following Semantic Versioning the version number should be bumped to 2.0.0.

timmhirsens commented 6 years ago

Yup, probably the smart thing to do. Will still have to check if there is a way for me to find out if any extensions are depending on the identifiers.

JimiC commented 6 years ago

From what I know, only file icon extensions and the client of the said extension, if that extension has a server service, are depending on the language ids. You may probably want to give a heads up to other file icon extension authors about this change.

ahmetcetin commented 5 years ago

@fr1zle when do you plan to merge this pr? I just those changes manually in my installation files, it worked, but would be nice to have it in distro.