Double-quotes within HTML attributes break syntax highlighting

timmhirsens / vscode-elixir

This plugin is no longer maintained!

MIT License

264 stars 50 forks source link

Double-quotes within HTML attributes break syntax highlighting #144

Open pinksynth opened 5 years ago

pinksynth commented 5 years ago

HTML attributes don't seem to recognize Elixir interpolation, causing them to catch double-quotes within Elixir and close attributes early. See attached image for explanation.

Example text:

  <img src="<%= Routes.static_path(@conn, "/images/phoenix.png") %>" alt="Phoenix Framework Logo"/>

Theme used: Atom One Dark

andreolvr commented 5 years ago

I'm using ElixirLS, and since it's based on this extension, i'm facing the same problem. Using ElixirLS and this extension together seems to solve the problem, but i can't make Emmet work when using this other extension. Do you have any updates on this?

chaoslogick commented 5 years ago

@andreolvr

make Emmet work when using this other extension

Had this issue, came across this thread. The double quote situation is fixed using the two extensions as you suggested. My Emmet is working however, and I believe it is because I added "HTML (EEx)": "html", to emmet.includeLanguages in settings.json. I can't recall where, but I had read somewhere that there was some change in EEx (the second capital letter is important?) and this is how it needed to be added to Emmet. I'm sure someone has deeper insight to this.

jamilabreu commented 4 years ago

Seeing the same - @fr1zle, any idea what might be causing it?