timmyfaraday / HarmonicPowerModels.jl

An extension package of PowerModels.jl for Harmonic (Optimal) Power Network
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

PSCC Paper: Bugs in Equations? #12

Closed frederikgeth closed 2 years ago

frederikgeth commented 2 years ago

https://github.com/timmyfaraday/HarmonicPowerModels.jl/blob/12b24922cfd96114c69605d01c4aa7cf8edd8b3a/src/form/iv.jl#L110

https://github.com/timmyfaraday/HarmonicPowerModels.jl/blob/12b24922cfd96114c69605d01c4aa7cf8edd8b3a/src/form/iv.jl#L146

let's talk later

frederikgeth commented 2 years ago

bugs confirmed, will address in PR #11

frederikgeth commented 2 years ago

there was another one in the transformer model, but they have all been addressed now

timmyfaraday commented 2 years ago

This can be closed?

frederikgeth commented 2 years ago

can be closed after you review/merge PR #11