search

timmyomahony / craft-matrix-field-preview

Configure a screenshot preview for all your matrix field blocks, giving your clients a better publishing experience.
https://plugins.craftcms.com/matrix-field-preview
Other
16 stars 4 forks source link

[enhancement] Config in project.yaml #102

Open S-n-d opened 2 years ago

S-n-d commented 2 years ago

Hi Timmy,

First of all, great plugin! Love it!

Quick question: why are the plugin settings stored in the database? Would it not be best if the settings are stored in the project.yaml config file? This way we won't have to sync database whenever changes to settings are made. Would it also be possible to store the links to the screenshots themselves in the project config?

I think it would be nice to have all the settings be decoupled from database. It integrates better with a git workflow.

Cheers!

timmyomahony commented 2 years ago

Hi @S-n-d thanks for raising the issue. I'm definitely considering this. The main reason at the moment is that volumes aren't always environment dependent, so storing them in the project.yaml doesn't always make sense. For example you might be using a local volume for development but a remote (e.g. S3) on staging or production. Saving the previews paths in the project.yaml wouldn't take this into consideration and therefore the paths wouldn't work correctly. It might be possible to offer both approaches though.

paulgoodfield commented 1 year ago

@timmyomahony Are there any further thoughts on this? Am using the plugin on a client site where allowAdminChanges is false on the production site which means I can't upload the relevant preview images directly on there via the CP. Also, the site in question has form plugin running which collects user submissions which means I can't just upload the images locally then overwrite the db as there is risk of losing data.

sanderpotjer commented 1 year ago

Was about to create an issue for this as well, would be great to use the configuration instead of the database. Especially for sites using multiple stages of deployments.

ZJensenDev commented 1 year ago

Bumping this feature, running into issues as others have stated. We are having to do a content freeze to implement this and it makes deploying a nightmare.

If including in the config isn't an option then the field preview options need to at least be accessible outside of settings so that they can be changed in a production environment.

timmyomahony commented 1 year ago

I'm going to start exploring this in a bit more detail, as it seems to be a popular feature.

Bear in mind that you can still access the matrix field preview settings page directly, even in production by visiting: /admin/matrix-field-preview/settings/. It's a bit of a stop-gap solution but can help when you need to update without changing the site's config.php

elenadiepstraten commented 1 year ago

Oeh! I am really excited for this feature. When this is implemented it would be a really great plugin for our company! Excited to hear more :)

benoitblancquaert commented 1 year ago

Great news! Storing the settings in Project Config would be a big win in my book.

timmyomahony commented 1 year ago

Would like to get more feedback on this feature from people if possible. I've created a discussion here:

https://github.com/weareferal/craft-matrix-field-preview/discussions/114