search

timmyomahony / craft-matrix-field-preview

Configure a screenshot preview for all your matrix field blocks, giving your clients a better publishing experience.
https://plugins.craftcms.com/matrix-field-preview
Other
16 stars 4 forks source link

Can't reorder blocks #127

Closed daltonrooney closed 3 months ago

daltonrooney commented 4 months ago

When I try to reorder a matrix block using the drag handle, I get a console error: TypeError: null is not an object (evaluating 't.target.querySelectorAll') and my change is not saved.

timmyomahony commented 3 months ago

Apologies for the delay here. I assume this was with the Craft 4 version, using matrix fields (as opposed to Neo fields)? There's a new version 5.0 out now that might address the issue, in the meantime could you let me know what version you were using?

daltonrooney commented 3 months ago

That's right, it's the Craft 4 version. We haven't moved too many of our existing sites to Craft 5 yet, any chance of a back-port to the Craft 4 version?

It's not something that will come up often for us since we're building new sites on Craft 5, but it would be nice to be able to edit the sort order for some of our existing sites if we decide to add new blocks.

timmyomahony commented 3 months ago

Happy to add a fix to version 4, but I can't replicate the issue at the moment. What version of Craft and the plugin are you using? Also, what other plugins have you got installed?

The Matrix Field Preview doesn't use querySelectorAll so I'm wondering where that's coming from.

Just to confirm, here's what I'm doing (Craft 4.11.1 and version 4.1.3 of the plugin):

CleanShot 2024-08-08 at 20 38 26

timmyomahony commented 3 months ago

Just to follow up here, I wonder is there another plugin injecting some JS/CSS onto control panel pages?

daltonrooney commented 3 months ago

Thanks for the follow-up @timmyomahony. This appears to have been an older Craft CMS issue in Safari only, which may be why you had trouble reproducing the issue. It was fixed in Craft 4.8.8: https://github.com/craftcms/cms/blob/4.x/CHANGELOG.md#488---2024-04-09

Sorry to bother you with this!