search

timmywheels / github-api-tutorial

👨‍💻⚡️🛠 A Quick Tutorial on Building a Simple Web App w/ the GitHub API
https://codesnippet.io/github-api-tutorial
23 stars 22 forks source link

The App is just One Run #1

Open jdevfullstack opened 4 years ago

jdevfullstack commented 4 years ago

Even in GitHub Pages, the app is actually working. But as I tested it, there is just one problem: it only run once.

For example, when you load the page and you search for one user, it will work, but once you search for another user and click Submit, data will not load. There is no script and button to clear the content of the web page.

timmywheels commented 4 years ago

Hi @xdvrx1 thanks for reading! Would you be willing to submit a pull request with your proposed changes?

jdevfullstack commented 4 years ago

If I have time, I'll do that. Thanks for the response.

jdevfullstack commented 3 years ago

Thanks for the changes, it's now working by attaching the searches at the bottom, but can we still add a clear button? or simply when there is a new entry, the page will automatically delete the last one? Thanks.

jdevfullstack commented 3 years ago

this is very simple, if you want to have the banner for a repo, go to Settings and you'll see there Social Preview, you need to upload an image,

if this is a site, say, in github.io domain, just insert one image, and that will automatically be the social preview,

On Thu, Oct 22, 2020 at 5:16 AM Pt. Prashant tripathi < notifications@github.com> wrote:

Acculty I was thinking 🤔, how can we access repo social preview banner🖼️

[image: IMG_20201022_024418] https://user-images.githubusercontent.com/26687933/96788115-88acf280-1410-11eb-946f-d29a5dadecc3.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timwheelercom/github-api-tutorial/issues/1#issuecomment-713882170, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALHJF4H6LXHB23LBC5K5VNTSL5FRLANCNFSM4QCYR5HA .

PtPrashantTripathi commented 3 years ago

Not like that , I think you didn't get my point, I am want It will automatically show the banner of that repo, in that card (if any available)

Pt. Prashant Tripathi web : https://ptprashanttripathi.github.io

On Sun, 25 Oct, 2020, 7:36 PM xdvrx1, notifications@github.com wrote:

this is very simple, if you want to have the banner for a repo, go to Settings and you'll see there Social Preview, you need to upload an image,

if this is a site, say, in github.io domain, just insert one image, and that will automatically be the social preview,

On Thu, Oct 22, 2020 at 5:16 AM Pt. Prashant tripathi < notifications@github.com> wrote:

Acculty I was thinking 🤔, how can we access repo social preview banner🖼️

[image: IMG_20201022_024418] < https://user-images.githubusercontent.com/26687933/96788115-88acf280-1410-11eb-946f-d29a5dadecc3.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/timwheelercom/github-api-tutorial/issues/1#issuecomment-713882170 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ALHJF4H6LXHB23LBC5K5VNTSL5FRLANCNFSM4QCYR5HA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/timwheelercom/github-api-tutorial/issues/1#issuecomment-716153805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLTTPK3APBAHNNOS5PUEJTSMQWFVANCNFSM4QCYR5HA .