timnat / DifCover

The DifCover pipeline aims to identify regions in a reference genome for which the read coverage of a sample1 to the reference is significantly different from the read coverage of a sample2. “Significantly different” is determined by user defined threshold on a ration between average coverages of given samples. The pipeline allows to exclude from a consideration the under-represented fragments (with low coverage in sequencing of both samples) and/or the regions that carry repetitive sequences. Both cases can be misleading in the coverage analysis. The DifCover pipeline is specifically oriented to the analysis of large genomes and can handle very fragmented assemblies.
MIT License
4 stars 2 forks source link

Replaces fname char with std::string #4

Open nikostr opened 3 months ago

nikostr commented 3 months ago

Hi! When I tried compiling this locally my binary refuses to recognize the files I provide it. I'm not sure what's up with that, but declaring fname as a std::string instead of using strncat solves the issue for me. This also removes a warning. I'm not super experienced in C++, so I'm terribly sorry if this misses something.

timnat commented 3 months ago

Thank you nikostr, If it makes things work, changes are fine and welcome. I am busy at the moment but hope to take a closer look in a couple of weeks, try it with conda and so on...

пт, 31 мая 2024 г. в 15:58, nikostr @.***>:

Hi! When I tried compiling this locally my binary refuses to recognize the files I provide it. I'm not sure what's up with that, but declaring fname as a std::string instead of using strncat solves the issue for me. This also removes a warning. I'm not super experienced in C++, so I'm terribly sorry if this misses something.

You can view, comment on, or merge this pull request online at:

https://github.com/timnat/DifCover/pull/4 Commit Summary

File Changes

(2 files https://github.com/timnat/DifCover/pull/4/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/timnat/DifCover/pull/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGJB6YTZV2MFCVNYKB2KI3ZFDI6VAVCNFSM6AAAAABITMACM6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDQNJQGYZTGMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>