Open nikostr opened 3 months ago
Thank you nikostr, If it makes things work, changes are fine and welcome. I am busy at the moment but hope to take a closer look in a couple of weeks, try it with conda and so on...
пт, 31 мая 2024 г. в 15:58, nikostr @.***>:
Hi! When I tried compiling this locally my binary refuses to recognize the files I provide it. I'm not sure what's up with that, but declaring fname as a std::string instead of using strncat solves the issue for me. This also removes a warning. I'm not super experienced in C++, so I'm terribly sorry if this misses something.
You can view, comment on, or merge this pull request online at:
https://github.com/timnat/DifCover/pull/4 Commit Summary
- e0f4ac4 https://github.com/timnat/DifCover/pull/4/commits/e0f4ac49aa6f6d3446eed5183ea585f7bea31c34 Replaces fname char with std::string
File Changes
(2 files https://github.com/timnat/DifCover/pull/4/files)
- M dif_cover_scripts/from_unionbed_to_ratio_per_window_CC0 https://github.com/timnat/DifCover/pull/4/files#diff-d09ef88a1a85d8cef864b368a35828fea034ac6b3e413944257f0d075ba83c82 (0)
- M dif_cover_scripts/from_unionbed_to_ratio_per_window_CC0.cpp https://github.com/timnat/DifCover/pull/4/files#diff-900145791bb40a8d8a95a8a6ae5035b4f8d1ad9a4714c724746773f907b6b58f (6)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/timnat/DifCover/pull/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGJB6YTZV2MFCVNYKB2KI3ZFDI6VAVCNFSM6AAAAABITMACM6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDQNJQGYZTGMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi! When I tried compiling this locally my binary refuses to recognize the files I provide it. I'm not sure what's up with that, but declaring
fname
as astd::string
instead of usingstrncat
solves the issue for me. This also removes a warning. I'm not super experienced in C++, so I'm terribly sorry if this misses something.