timo-reymann / intellij-mjml-support

MJML support for the IntelliJ Platform.
https://timo-reymann.github.io/intellij-mjml-support/
Other
26 stars 11 forks source link

Add missing tag attributes based on MJML documentation #194

Closed andrewalba closed 9 months ago

andrewalba commented 9 months ago

✨ feat(constants_attributes.kt, BuiltInMjmlTagInformationProvider.kt) add new attributes and update existing ones

🔧 refactor(BuiltInMjmlTagInformationProvider.kt): replace ATTRIBUTE_CONTAINER_BACKGROUND_COLOR with new attribute for inner element background color

🎨 style(BuiltInMjmlTagInformationProvider.kt): add new attributes for border, link name, width based on query, letter-spacing, background position, role, table layout

🐛 fix(BuiltInMjmlTagInformationProvider.kt): correct the attribute for inner element background color

These changes were made to enhance the functionality and improve the readability of the code.

Resolved some issues with some tags that had "Unknown attribute {0} for mjml tag {1}" warnings.

Description

Added and or updated missing tag attributes to resolve "Unknown attribute {0} for mjml tag {1}" warnings for some tags based on the current MJML documentation (https://documentation.mjml.io/).

Examples:

<mj-wrapper background-position="top center"></mj-wrapper>

<mj-image sizes="(max-width: 25px) 100vw, 25px" />

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

timo-reymann commented 9 months ago

Will be released with 3.3.1, thanks for your contribution 🚀