search

timo / json_fast

a naive imperative json parser in perl6, to evaluate performance against JSON::Tiny
Artistic License 2.0
27 stars 20 forks source link

Add tests from JSONTestSuite #49

Closed Kaiepi closed 6 years ago

Kaiepi commented 6 years ago

Fixes #47

timo commented 6 years ago

One of the new lines apparently makes github (and git itself) believe that the test file is binary now; perhaps you can find out which it is and use some escaping to make it plain-old text again?

Also i'd appreciate a comment in the arrays that tells where the tests from this source start, and maybe also a link to the original.

Other than that, good work, thanks!

Kaiepi commented 6 years ago

The tests that were making the file appear to be binary were the ones that used unescaped UTF16 and U+FFFF. I removed those, so now it's back to being a text file.

I'll update the pullreq once Rakudo finishes building and I get a chance to test again Edit: updated

timo commented 6 years ago

Sorry about the nitpicking, but could you split replacing << >> with « » into a separate commit so that they show up "properly" as different changes in a "git blame"?

Kaiepi commented 6 years ago

Sure

timo commented 6 years ago

fantastic, thanks!