search

timocov / ts-transformer-minify-privates

A TypeScript custom transformer which renames private class members
MIT License
52 stars 5 forks source link

Support typescript 4.8 #21

Closed bo4arovpavel1989 closed 2 years ago

bo4arovpavel1989 commented 2 years ago

@timocov , hi! Since typescript 4.8 there are some breaking changes https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#decorators-are-placed-on-modifiers-on-typescripts-syntax-trees could you please review this pull request and release a new (major?) version of the package, if it's ok?

dfilatov commented 2 years ago

@timocov Hi, Evgeny! Could you take a look here?

bo4arovpavel1989 commented 2 years ago

Hi @dfilatov @bo4arovpavel1989, sorry for late reply. Apart from a comment, just curious what it is the reason that you're using this package over https://github.com/timocov/ts-transformer-properties-rename ?

we use a lot of decorators in the project, but 'ts-transformer-properties-rename'-package would rename private decorated class members as well as not-decorated, which will be broken after mangling by terser

timocov commented 2 years ago

we use a lot of decorators in the project, but 'ts-transformer-properties-rename'-package would rename private decorated class members as well as not-decorated, which will be broken after mangling by terser

@bo4arovpavel1989 can you create an issue for this bug in that repo please (with some examples please as I haven't worked with decorators much and might miss something)? I'd rather to maintain 1 repo than 2 that do pretty similar/the same things :) Or at least we would be aware of that

timocov commented 2 years ago

The fix has been released in v0.5.0. Thanks for contributing @bo4arovpavel1989!