search

timofei-iatsenko / angular-cc-library

Library to support Credit Card input masking and validation
MIT License
82 stars 71 forks source link

chore: updating to angular 17 #122

Closed s-torrisi closed 7 months ago

s-torrisi commented 7 months ago

first time forking and updating an open source library, hope i didn't mess anything up!

timofei-iatsenko commented 7 months ago

does library generated with angular 17 completely incompatible with angular 16? I mean, may be we should just expand compatiblity range instead of setting strict angular 17 peer dependency?

s-torrisi commented 7 months ago

I did try the library in angular 16 but it gives me errors, i did also find some errors while trying to use the library on my project I did not yet localize the errors, they could be on my side only caused by the updates.

I will try to run more tests and follow up with more info

s-torrisi commented 7 months ago

Ok, it looks like i got the problem because npm link generates an injection error for some obscure reason if you have the preserveSymlinks option set to false in angular . The library is working on angular 17, everything should be good to go

timofei-iatsenko commented 7 months ago

I updated version as well as other tools and also added support of standalone directives https://github.com/thekip/angular-cc-library/pull/123

timofei-iatsenko commented 7 months ago

The new version v3.3.0 is released