search

timofei-iatsenko / angular-cc-library

Library to support Credit Card input masking and validation
MIT License
82 stars 71 forks source link

Angular 18 Support #124

Closed s-torrisi closed 2 months ago

s-torrisi commented 4 months ago

At the moment the library does not support angular 18

Is there anything I can do to help update it or is there a planned release date?

wen9218 commented 4 months ago

@thekip , I am waiting for new release of matching angular 18 Thanks

born2net commented 4 months ago

yes please, need to move to ngv18 and waiting on this lib <3 TX!

cwithhart commented 2 months ago

Any update on this? 18 has been out for quite sometime.

cwithhart commented 2 months ago

Can someone help me out. I tried updating the library to 18 but getting an issue when running ng test. It looks like the require() for non es modules isnt working and im not exactly sure the answer. (The code is working just not the tests) https://github.com/cwithhart/angular-cc-library/tree/angular-18-update

s-torrisi commented 2 months ago

@cwithhart can you add me as maintainer to your fork? I created a pull request that would fix the problem with the tests (It is mainly related to an old yarn version and to standalone components)

born2net commented 2 months ago

that would be great if more people will work on the project, tx

s-torrisi commented 2 months ago

@thekip, can you add me as maintainer to this project too? I'd be glad to help maintain this project also in the future

timofei-iatsenko commented 2 months ago

guys, if you want to participate i would be glad to accept PR's

I think updating to the Angular 18 should be as easy as just a peer dep version bump.

s-torrisi commented 2 months ago

There it is, I realized it wasn't necessary to merge my code to the other fork before creating the PR:

https://github.com/thekip/angular-cc-library/pull/125

s-torrisi commented 2 months ago

@thekip the publishing of the app has failed, have you had a chance to take a look at it?

s-torrisi commented 2 months ago

@timofei-iatsenko any news?

timofei-iatsenko commented 2 months ago

Sorry, was busy on the job. Will try to bring the pipeline to live now

timofei-iatsenko commented 2 months ago

https://www.npmjs.com/package/angular-cc-library/v/3.4.0