search

timofei-iatsenko / angular-cc-library

Library to support Credit Card input masking and validation
MIT License
82 stars 71 forks source link

Looking for maintainers #62

Closed nogorilla closed 4 years ago

nogorilla commented 4 years ago

Looking for help to maintain or take ownership of this project. I no longer work with Angular so I do not use or keep up with any changes. As many still use this library, I'm happy to let it go to someone else who has the time and ability to keep it active.

evansmwendwa commented 4 years ago

Hi @nogorilla I am interested in keeping this project alive and updated. I can help in maintaining the project

nogorilla commented 4 years ago

@evansmwendwa thanks, just added you as a collaborator. I'll working on updating NPM as well

evansmwendwa commented 4 years ago

Thanks for the good work. I will try and add ivy support in the coming days

timofei-iatsenko commented 4 years ago

@evansmwendwa how it's going? I'm going to port it latest angular right now because I need it asap on our project

evansmwendwa commented 4 years ago

Go ahead and let me know if you need assistance

timofei-iatsenko commented 4 years ago

done, https://github.com/nogorilla/angular-cc-library/pull/64

nogorilla commented 4 years ago

@evansmwendwa just gave you maintainer access on NPM, can you confirm?

evansmwendwa commented 4 years ago

Got it. Thanks

timofei-iatsenko commented 4 years ago

@evansmwendwa when you a going to spend a time and check/merge my PR? Maybe it's better to give me contributor access as well, because i'm going to create few more PR's soon, and resolve couple existing bugs/feature requests.

timofei-iatsenko commented 4 years ago

@evansmwendwa @nogorilla guys, don't want to be rude but want to push you to check PR and merge it, people are waiting. @evansmwendwa you had to think before taking responsibility if you have no time for it.

evansmwendwa commented 4 years ago

@thekip I don't mean to rude here but I will have a look at it when I do. If you feel blocked I suggest you either request to be a maintainer also, use your fork or go proprietary. Among OSS rights, time is not one of them

timofei-iatsenko commented 4 years ago

If you feel blocked I suggest you either request to be a maintainer also

I did it 4 days ago:

Maybe it's better to give me contributor access as well, because i'm going to create few more PR's soon

timofei-iatsenko commented 4 years ago

Well, let's do it in different way, @nogorilla please give me maintainer access for this repo and npm.

nogorilla commented 4 years ago

@thekip what's your npm username?

timofei-iatsenko commented 4 years ago

https://www.npmjs.com/settings/thekip/profile

nogorilla commented 4 years ago

getting a 404 error for that page

timofei-iatsenko commented 4 years ago

seems it is a private page, doesn't matter, account name is thekip

nogorilla commented 4 years ago

just to confirm: https://www.npmjs.com/~thekip

timofei-iatsenko commented 4 years ago

yep

timofei-iatsenko commented 4 years ago

Thanks, got it. PR is merged, continue working on the project. 👍