timofeysie / khipu

Electron PWA starter
MIT License
4 stars 1 forks source link

Create link to Wikipedia on the details page #55

Closed timofeysie closed 3 years ago

timofeysie commented 3 years ago

The issue with this is if we should be passing an object via the router to the detail page, or include everything in the url.

  1. Passing the object via the router is easy, but adds a dependency so that the url cannot be shared.

  2. Passing the url via the url seems inane, but is a possibility.

  3. A third option is to make an extra call to firebase to get the details stored there, which is OK if that extra network call is acceptable. But we are already making three api calls on this page. Adding an extra one seems a bit much.

  4. Another option similar to 1 is to use a service to store the data. This has the same drawback that the link to a detail page cannot be shared, because it depends on data from the list.

It looks like either 2 or 3 is the way to go. Two is awkward, but the fastest way forward at this point.