Closed brettlounsbury closed 1 year ago
Yes, I think a new method makes sense and I'm totally open to a PR :)
@timofurrer - I submitted a PR here: https://github.com/timofurrer/w1thermsensor/pull/119
Code was merged
@timofurrer - do you have a timeline for releasing the newest version, at which point we can close this out?
Gentle nudge @timofurrer - can you cut a new release with the latest changes so that they can be consumed from pypi?
@brettlounsbury sorry that it took so long, release v2.3.0 just landed on PyPI: https://pypi.org/project/w1thermsensor/2.3.0
Description
It seems to me that most of the DS18B20 sensors I use need to be calibrated (I use this method). It would be awesome if the library could return a corrected value based on calibration data provided to it.
Would you be willing to accept a pull request where the library takes a calibration_data dict and if that data is provided, it returns corrected temperatures based on the calibration data instead of the raw values? Alternately, I could write a second method that returns the corrected temperatures based on that calibration data if you'd prefer that.
Guidelines