timohirt / terraform-provider-hetznerdns

Terraform provider for Hetzner DNS
Mozilla Public License 2.0
106 stars 21 forks source link

DNS record will not be destroyed, when DNS zone has the prevent_destroy flag #38

Open soerenkornetzki opened 2 years ago

soerenkornetzki commented 2 years ago

I have a DNS zone (example.com), in which I deploy multiple instances of the same Terraform script (with different names, of course).

To prevent the DNS zone from being deleted when terraform destroy has been issued, I have protected my DNS zone from being destroyed.

resource "hetznerdns_zone" "example_com_dns_zone" {
  name = "example.com"
  ttl  = 86400
  lifecycle { prevent_destroy = true }
}

Unfortunately, on a destroy, no DNS records will be destroyed, even though I marked the DNS records as "do not prevent destroy".

resource "hetznerdns_record" "server_example_com_dns_record_a" {
  zone_id = hetznerdns_zone.example_com_dns_zone.id
  name    = "server"
  type    = "A"
  value   = "127.0.0.1"
  ttl     = 60
  lifecycle { prevent_destroy = false }
}

Please delete DNS records, when they are not protected, but the DNS zone is.

The current version (2.1.0) will not delete the DNS records, despite being not protected.

timohirt commented 1 year ago

Oh, prevent_destroy lifecycle option is not supported currently. I see the value of this and I'm happy for contributions.