search

timohirt / terraform-provider-hetznerdns

Terraform provider for Hetzner DNS
Mozilla Public License 2.0
106 stars 21 forks source link

[bump] go module to "v2" #41

Closed icepuma closed 2 years ago

icepuma commented 2 years ago

Hey,

I'm currently developing a Pulumi Provider wrapping this Terraform Provider. Therefore I want to follow the go modules semantic and bump this module to v2.

Best regards icepuma

icepuma commented 2 years ago

To make it work with go.mod, a new release has to be tagged.

Afterwards, we're able to use the lib like so:

require (
  github.com/timohirt/terraform-provider-hetznerdns/v2 v2.2.0
)
timohirt commented 2 years ago

@icepuma thank you for your contribution. In order to get the acceptance tests running, I need to merge the PR back in this repo. Could you please change the PR target to another branch. Like v2 or something?

Then the action can use the secret in my repo to run the test.

icepuma commented 2 years ago

Yeah, sure. Will do it later!

icepuma commented 2 years ago

I can create a branch on my end and target main, but a target on your end isn't possible. Or did you mean a branch in my fork?

icepuma commented 2 years ago

2022-07-08-144101_1270x370_scrot

I think you have to create a v2 branch on your repo and then I can PR against it :+1: